Create factorial_iterative.py#13793
Closed
agarwalpranay02 wants to merge 5 commits intoTheAlgorithms:masterfrom
Closed
Create factorial_iterative.py#13793agarwalpranay02 wants to merge 5 commits intoTheAlgorithms:masterfrom
agarwalpranay02 wants to merge 5 commits intoTheAlgorithms:masterfrom
Conversation
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/factorial_iterative.py
Outdated
| @@ -0,0 +1,16 @@ | |||
| def factorial_iterative(n: int) -> int: | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/factorial_iterative.py, please provide doctest for the function factorial_iterative
Please provide descriptive name for the parameter: n
Address review: add doctests and descriptive parameter name
algorithms-keeper
bot
removed
require descriptive names
for more information, see https://pre-commit.ci
Add iterative GCD implementation
algorithms-keeper
bot
added
the
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/gcd_iterative.py
Outdated
| @@ -0,0 +1,13 @@ | |||
| def gcd_iterative(a: int, b: int) -> int: | |||
There was a problem hiding this comment.
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
Fix: replace single letter parameters with descriptive names
algorithms-keeper
bot
removed
the
require descriptive names
Member
|
We already have it in https://github.com/TheAlgorithms/Python/blob/master/maths/factorial.py#L6-L35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Created a new Python file
factorial_iterative.pyimplementing the factorial function using an iterative approach. This algorithm was not present earlier. Included type hints and a Wikipedia reference as required.Checklist